twick00 commented on code in PR #208:
URL: https://github.com/apache/jclouds/pull/208#discussion_r1702309096
##########
providers/azureblob/src/main/java/org/jclouds/azureblob/blobstore/AzureBlobStore.java:
##########
@@ -440,9 +440,10 @@ public String completeMultipartUpload(MultipartUpload mpu,
List<MultipartPart> p
return sync.putBlockList(mpu.containerName(), azureBlob, blocks.build());
}
- static String makeBlockId(int partNumber) {
- return BaseEncoding.base64Url().encode(Ints.toByteArray(partNumber));
- }
+ static String makeBlockId(int partNumber) {
+ // Azure expects a base64-encoded string ONLY. It does not support
base64url encoding.
+ return BaseEncoding.base64().encode(Ints.toByteArray(partNumber));
Review Comment:
The url encoding is handled downstream by `org.jclouds.util.Strings2`'s
`urlEncode` method.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@jclouds.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
