cxzl25 commented on a change in pull request #2162: URL: https://github.com/apache/incubator-kyuubi/pull/2162#discussion_r829680339
########## File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkConsoleProgressBar.scala ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.kyuubi + +import java.time.{Instant, ZoneId} +import java.time.format.DateTimeFormatter +import java.util.{Locale, Timer, TimerTask} +import java.util.concurrent.ConcurrentHashMap + +import scala.collection.JavaConverters._ + +import org.apache.kyuubi.Logging +import org.apache.kyuubi.operation.Operation + +class SparkConsoleProgressBar( + operation: Operation, + liveStages: ConcurrentHashMap[StageAttempt, StageInfo]) Review comment: Yes, the previously implemented v1 version is obtained through `SparkContext.statusStore.activeStages()`, but each `Operation` registers a `SQLOperationListener`, so I avoid each Operation calls `SparkContext.statusStore.activeStages()` ########## File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SQLOperationListener.scala ########## @@ -43,6 +44,11 @@ class SQLOperationListener( private val activeJobs = new java.util.HashSet[Int]() private val activeStages = new java.util.HashSet[Int]() private var executionId: Option[Long] = None + private val liveStages = new ConcurrentHashMap[StageAttempt, StageInfo]() + + private val consoleProgressBar = new SparkConsoleProgressBar( Review comment: TODO add a configuration When true, show the progress bar in the session log. ########## File path: externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/kyuubi/SparkConsoleProgressBar.scala ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.spark.kyuubi + +import java.time.{Instant, ZoneId} +import java.time.format.DateTimeFormatter +import java.util.{Locale, Timer, TimerTask} +import java.util.concurrent.ConcurrentHashMap + +import scala.collection.JavaConverters._ + +import org.apache.kyuubi.Logging +import org.apache.kyuubi.operation.Operation + +class SparkConsoleProgressBar( + operation: Operation, + liveStages: ConcurrentHashMap[StageAttempt, StageInfo]) + extends Logging { + // Carriage return + private val CR = '\r' + // Update period of progress bar, in milliseconds + private val updatePeriodMSec = 200L Review comment: TODO add a configuration. Configure the update interval. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
