yaooqinn commented on a change in pull request #2174:
URL: https://github.com/apache/incubator-kyuubi/pull/2174#discussion_r830637065
##########
File path:
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/operation/ExecuteStatement.scala
##########
@@ -31,6 +32,11 @@ class ExecuteStatement(
override val shouldRunAsync: Boolean,
queryTimeout: Long)
extends HiveOperation(OperationType.EXECUTE_STATEMENT, session) {
+
+ private val operationLog: OperationLog =
OperationLog.createOperationLog(session, getHandle)
Review comment:
this is not necessary. this operation file will never be visit at read
side.
I have already reimplemented the interface, we shall add a unit test for
this to verify it's ok or not(which we shall find out why)
https://github.com/apache/incubator-kyuubi/blob/f22a14f1e50af6faad2a64902367af3f63a4ffc9/externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/operation/HiveOperationManager.scala#L96-L128
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
