deadwind4 commented on pull request #2206: URL: https://github.com/apache/incubator-kyuubi/pull/2206#issuecomment-1077266918
> If I understand correctly, the behavior of engine-specific properties defined in `kyuubi-default.conf` is different in Spark and Flink. For Spark, we can define the properties as-is, e.g. define `spark.driver.memory` in `kyuubi-default.conf` has a same effect with defining `spark.driver.memory` in `spark-defaults.conf`, but for Flink, user need to add a prefix `flink` in `kyuubi-defaults.conf`, e.g. define `flink.jobmanager.memory.heap.size` in `kyuubi-default.conf` has a same effect with defining `jobmanager.memory.heap.size` in `flink-conf.yaml`. > > I'm fine with prefix design, but we need to document such behavior clearly otherwise users may confusing when they use both Spark and Flink engines. I will split a new issue to achieve Flink doc including this below. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
