pan3793 commented on a change in pull request #2215:
URL: https://github.com/apache/incubator-kyuubi/pull/2215#discussion_r835855400
##########
File path:
kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation
for" +
" [SET
Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online
documentation for" +
+ " [Flink Configurations]" +
+
"(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
+ newOutput += ""
+ newOutput += ("For example:")
+ newOutput += ("```")
+ newOutput += ("flink.parallelism.default 2")
+ newOutput += ("flink.taskmanager.memory.process.size 5g")
Review comment:
Does 5g is the default value? We'd better use default value in example
##########
File path:
kyuubi-server/src/test/scala/org/apache/kyuubi/config/AllKyuubiConfiguration.scala
##########
@@ -203,8 +203,50 @@ class AllKyuubiConfiguration extends KyuubiFunSuite {
newOutput += ""
newOutput += ("Please refer to the Spark official online documentation
for" +
" [SET
Command](http://spark.apache.org/docs/latest/sql-ref-syntax-aux-conf-mgmt-set.html)")
+ newOutput += ""
+
+ newOutput += ("## Flink Configurations")
+ newOutput += ""
+ newOutput += ("### Via flink-conf.yaml")
newOutput += ""
+ newOutput += ("Setting them in `$FLINK_HOME/conf/flink-conf.yaml`" +
+ " supplies with default values for SQL engine application." +
+ " Available properties can be found at Flink official online
documentation for" +
+ " [Flink Configurations]" +
+
"(https://nightlies.apache.org/flink/flink-docs-master/docs/deployment/config/)")
+ newOutput += ""
+
+ newOutput += ("### Via kyuubi-defaults.conf")
+ newOutput += ""
+ newOutput += ("Setting them in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`" +
+ " supplies with default values for SQL engine application too." +
+ " These properties of `flink.` prefix will override all settings in" +
+ " `$FLINK_HOME/conf/flink-conf.yaml`.")
+ newOutput += ""
+ newOutput += ("For example:")
+ newOutput += ("```")
+ newOutput += ("flink.parallelism.default 2")
+ newOutput += ("flink.taskmanager.memory.process.size 5g")
Review comment:
Does 5g is the default value? We'd better use the default value in
example
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
