pan3793 commented on pull request #2246: URL: https://github.com/apache/incubator-kyuubi/pull/2246#issuecomment-1081508813
> @pan3793 I check https://www.slf4j.org/faq.html#excludingJCL found that provides two methods to exclude commons - logging, I prefer to the second, what do you think? Your change does not implement option 2, it still in test scope. Personally I prefer option 1, because we don't need to declare versions for un-used deps. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
