pan3793 commented on a change in pull request #2265:
URL: https://github.com/apache/incubator-kyuubi/pull/2265#discussion_r840678956



##########
File path: docs/quick_start/quick_start.md
##########
@@ -170,6 +172,21 @@ To enable the Flink SQL engine, the `kyuubi.engine.type` 
in `$KYUUBI_HOME/conf/k
 kyuubi.engine.type FLINK_SQL
 ```
 
+### Trino Engine
+
+#### Setup Trino
+Different from Spark/Flink, you must have a Trino cluster first. Trino client 
stored in `$KYUUBI_HOME/externals/engines/trino`.
+
+#### Setup Kyuubi Trino Configration
+
+To enable the Trino engine, the `kyuubi.engine.type` need to be set as 
`TRINO`. And `session.engine.trino.connection.url` and 
`session.engine.trino.connection.catalog` are also necessary. You can set all 
those configs in `$KYUUBI_HOME/conf/kyuubi-defaults.conf`, or set them in your 
connection parameters.
+
+```bash
+kyuubi.engine.type TRINO
+session.engine.trino.connection.url http://localhost:8080    # Your trino 
cluster server url
+session.engine.trino.connection.catalog hive   # The default catalog connect 
to.

Review comment:
       Are you missing `kyuubi.` prefix here?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]



---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to