Nick-0723 commented on code in PR #2314:
URL: https://github.com/apache/incubator-kyuubi/pull/2314#discussion_r847015388
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/ProcBuilder.scala:
##########
@@ -185,6 +186,12 @@ trait ProcBuilder {
process
}
+ def killApplicationWrap(engineRefId: String): String =
Review Comment:
> Yeah, I mean merge two methods to one. And use `Left` to represent
`engineRefId` and Right to represent `line`
If it is merged into one, the implementation of the flink engine will also
needs to be modified
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
