yaooqinn commented on code in PR #2336:
URL: https://github.com/apache/incubator-kyuubi/pull/2336#discussion_r849028461
##########
build/dist:
##########
@@ -257,9 +253,8 @@ cp
"$KYUUBI_HOME/externals/kyuubi-flink-sql-engine/target/kyuubi-flink-sql-engin
cp
"$KYUUBI_HOME/externals/kyuubi-spark-sql-engine/target/kyuubi-spark-sql-engine_${SCALA_VERSION}-${VERSION}.jar"
"$DISTDIR/externals/engines/spark"
# Copy trino engines
-cp -r "$KYUUBI_HOME/externals/kyuubi-trino-engine/bin/"
"$DISTDIR/externals/engines/trino/bin/"
-chmod a+x "$DISTDIR/externals/engines/trino/bin/trino-engine.sh"
-cp
"$KYUUBI_HOME/externals/kyuubi-trino-engine/target/kyuubi-trino-engine_${SCALA_VERSION}-${VERSION}.jar"
"$DISTDIR/externals/engines/trino/jars"
+cp
"$KYUUBI_HOME/externals/kyuubi-trino-engine/target/kyuubi-trino-engine_${SCALA_VERSION}-${VERSION}.jar"
"$DISTDIR/externals/engines/trino"
+cp -r
"$KYUUBI_HOME/externals/kyuubi-trino-engine/target/scala-$SCALA_VERSION/jars/"
"$DISTDIR/externals/engines/trino"
Review Comment:
what's more, most of the dependencies here
- duplicate with kyuubi servers, making our release tar oversize
- uncurated, we don't carefully manage the transitive jars, the behavior
just inherits from the parent's maven-dependency-jar, which is dangerous for
making an apache-approved release.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
