SteNicholas commented on code in PR #2334:
URL: https://github.com/apache/incubator-kyuubi/pull/2334#discussion_r849710277
##########
externals/kyuubi-flink-sql-engine/bin/flink-sql-engine.sh:
##########
@@ -61,7 +61,7 @@ log_setting=(
)
if [ -n "$FLINK_SQL_ENGINE_JAR" ]; then
- exec $JAVA_RUN ${FLINK_SQL_ENGINE_DYNAMIC_ARGS} "${log_setting[@]}" -cp
${FULL_CLASSPATH} \
+ exec $JAVA_RUN ${FLINK_SQL_ENGINE_JAVA_OPTS}
${FLINK_SQL_ENGINE_DYNAMIC_ARGS} "${log_setting[@]}" -cp ${FULL_CLASSPATH} \
Review Comment:
Why not reuse the `FLINK_ENV_JAVA_OPTS` and `JVM_ARGS` variables of Flink? I
don't think this need to create new variables for Flink engine.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
