yaooqinn commented on code in PR #2353: URL: https://github.com/apache/incubator-kyuubi/pull/2353#discussion_r851002350
########## kyuubi-server/src/main/scala/org/apache/kyuubi/operation/BatchJobSubmission.scala: ########## @@ -0,0 +1,207 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.operation + +import java.nio.ByteBuffer +import java.util.{ArrayList => JArrayList, Locale} +import java.util.concurrent.TimeUnit + +import scala.collection.JavaConverters._ + +import org.apache.hive.service.rpc.thrift._ + +import org.apache.kyuubi.KyuubiException +import org.apache.kyuubi.config.KyuubiConf +import org.apache.kyuubi.engine.ProcBuilder +import org.apache.kyuubi.engine.spark.SparkBatchProcessBuilder +import org.apache.kyuubi.operation.FetchOrientation.{FETCH_FIRST, FETCH_NEXT, FETCH_PRIOR, FetchOrientation} +import org.apache.kyuubi.operation.log.OperationLog +import org.apache.kyuubi.server.api.v1.BatchRequest +import org.apache.kyuubi.session.KyuubiBatchSessionImpl +import org.apache.kyuubi.util.ThreadUtils + +class BatchJobSubmission(session: KyuubiBatchSessionImpl, batchRequest: BatchRequest) + extends KyuubiOperation(OperationType.UNKNOWN_OPERATION, session) { + + override def statement: String = "BATCH_JOB_SUBMISSION" + + override def shouldRunAsync: Boolean = true + + private lazy val _operationLog = OperationLog.createOperationLog(session, getHandle) + + private var builder: ProcBuilder = _ + + @volatile + private[kyuubi] var appIdAndUrl: Option[(String, String)] = None + + private var resultFetched: Boolean = _ + + private val applicationCheckInterval = + session.sessionConf.get(KyuubiConf.BATCH_APPLICATION_CHECK_INTERVAL) + private val applicationCheckExecutor = + ThreadUtils.newDaemonSingleThreadScheduledExecutor(s"application-checker-${session.batchId}") + + override def getOperationLog: Option[OperationLog] = Option(_operationLog) + + override protected def beforeRun(): Unit = { + OperationLog.setCurrentOperationLog(_operationLog) + setHasResultSet(false) + setState(OperationState.PENDING) + } + + override protected def afterRun(): Unit = { + OperationLog.removeCurrentOperationLog() + } + + override protected def runInternal(): Unit = { + val asyncOperation: Runnable = () => { + setState(OperationState.RUNNING) + try { + submitBatchJob() + setState(OperationState.FINISHED) + } catch onError() + } + try { + val opHandle = session.sessionManager.submitBackgroundOperation(asyncOperation) + setBackgroundHandle(opHandle) + } catch onError("submitting batch job submission operation in background, request rejected") + } + + private def submitBatchJob(): Unit = { + builder = Option(batchRequest.batchType).map(_.toUpperCase(Locale.ROOT)) match { + case Some("SPARK") => + new SparkBatchProcessBuilder( + session.user, + session.sessionConf, + session.batchId, + batchRequest, + getOperationLog) + + case _ => + throw new UnsupportedOperationException(s"Batch type ${batchRequest.batchType} unsupported") + } + + try { + info(s"Submitting ${batchRequest.batchType} batch job: $builder") + val process = builder.start + startApplicationChecker() + process.waitFor() + if (process.exitValue() != 0) { + throw new KyuubiException(s"Process exit with value ${process.exitValue()}") + } + } finally { + builder.close() + } + } + + private def startApplicationChecker(): Unit = { + val checker = new Runnable { + override def run(): Unit = { + if (appIdAndUrl.isEmpty) { + try { + builder match { + case sparkBatchProcessBuilder: SparkBatchProcessBuilder => + sparkBatchProcessBuilder.getApplicationIdAndUrl() match { + case Some(appInfo) => appIdAndUrl = Some(appInfo) + case _ => + } + + case _ => + } + } catch { + case e: Exception => error(s"Failed to check batch application", e) + } + } + } + } + + applicationCheckExecutor.scheduleAtFixedRate( Review Comment: why do we need to schedule it at fix rate? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
