wForget commented on code in PR #2364:
URL: https://github.com/apache/incubator-kyuubi/pull/2364#discussion_r851087996
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -69,6 +69,12 @@ abstract class SessionManager(name: String) extends
CompositeService(name) {
private val timeoutChecker =
ThreadUtils.newDaemonSingleThreadScheduledExecutor(s"$name-timeout-checker")
+ @volatile private var _limiter: Option[SessionLimiter] = None
+
+ protected def setSessionLimiter(limiter: SessionLimiter): Unit = {
Review Comment:
> @yaooqinn I need to decrement limit after close session, in
KyuubiSessionManager's closeSession method we can't seem to implement it well.
Because the session will be removed from handleToSession after closeSession.
Sorry, please ignore this comment, I have moved it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
