pan3793 commented on code in PR #2314:
URL: https://github.com/apache/incubator-kyuubi/pull/2314#discussion_r851940235
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -78,7 +78,12 @@ class FlinkProcessBuilder(
override protected def commands: Array[String] = Array(executable)
- override def killApplication(line: String =
lastRowsOfLog.toArray.mkString("\n")): String = {
+ override def killApplication(clue: Either[String, String]): String = clue
match {
Review Comment:
> ... and others call `killApplication()`
Then it is not testable
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -78,7 +78,12 @@ class FlinkProcessBuilder(
override protected def commands: Array[String] = Array(executable)
- override def killApplication(line: String =
lastRowsOfLog.toArray.mkString("\n")): String = {
+ override def killApplication(clue: Either[String, String]): String = clue
match {
Review Comment:
> ... and others call `killApplication()`
Then it is not testable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
