ulysses-you commented on code in PR #2421:
URL: https://github.com/apache/incubator-kyuubi/pull/2421#discussion_r855700835
##########
externals/kyuubi-hive-sql-engine/src/main/scala/org/apache/kyuubi/engine/hive/events/HiveEngineEvent.scala:
##########
@@ -30,8 +30,14 @@ case class HiveEngineEvent(
diagnostic: String,
settings: Map[String, String]) extends KyuubiEvent {
- override def partitions: Seq[(String, String)] =
- ("day", Utils.getDateFromTimestamp(startTime)) :: Nil
+ override def partitions: Seq[(String, String)] = {
+ // before engine is started, the start time is 0L, the partition use
current day.
+ if (startTime == 0) {
Review Comment:
if a engine is not started how can we go into this code path , is it a bug ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
