ulysses-you commented on code in PR #2435: URL: https://github.com/apache/incubator-kyuubi/pull/2435#discussion_r855748739
########## externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/session/SparkSQLSessionManager.scala: ########## @@ -50,6 +53,39 @@ class SparkSQLSessionManager private (name: String, spark: SparkSession) val operationManager = new SparkSQLOperationManager() private lazy val singleSparkSession = conf.get(ENGINE_SINGLE_SPARK_SESSION) + private lazy val shareLevel = ShareLevel.withName(conf.get(ENGINE_SHARE_LEVEL)) + + private lazy val userIsolatedSparkSession = conf.get(ENGINE_USER_ISOLATED_SPARK_SESSION) + private lazy val userIsolatedSparkSessionCache = new ConcurrentHashMap[String, SparkSession]() Review Comment: ideally, It will be unexpect for user if we release the cache that users will lose their context. yeah, we can use guava cache for some inactive timeout release. Will add a new config for that. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
