zhaomin1423 commented on code in PR #2579:
URL: https://github.com/apache/incubator-kyuubi/pull/2579#discussion_r866893392
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -80,13 +86,17 @@ class FlinkProcessBuilder(
env.get("HADOOP_CONF_DIR").foreach(classpathEntries.add)
env.get("YARN_CONF_DIR").foreach(classpathEntries.add)
env.get("HBASE_CONF_DIR").foreach(classpathEntries.add)
- val hadoopClasspath = env.get("HADOOP_CLASSPATH")
- if (hadoopClasspath.isEmpty) {
- throw KyuubiSQLException("HADOOP_CLASSPATH is not set! " +
- "For more detail information on configuring HADOOP_CLASSPATH" +
-
"https://kyuubi.apache.org/docs/latest/deployment/settings.html#environments";)
+ val hadoopCp = env.get(FLINK_HADOOP_CLASSPATH)
+ hadoopCp.foreach(classpathEntries.add)
+ val extraCp = conf.get(ENGINE_FLINK_EXTRA_CLASSPATH)
+ extraCp.foreach(classpathEntries.add)
+ if (hadoopCp.isEmpty && extraCp.isEmpty) {
+ throw new KyuubiException(s"The conf of ${FLINK_HADOOP_CLASSPATH} or " +
Review Comment:
or -> and
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/flink/FlinkProcessBuilder.scala:
##########
@@ -80,13 +86,17 @@ class FlinkProcessBuilder(
env.get("HADOOP_CONF_DIR").foreach(classpathEntries.add)
env.get("YARN_CONF_DIR").foreach(classpathEntries.add)
env.get("HBASE_CONF_DIR").foreach(classpathEntries.add)
- val hadoopClasspath = env.get("HADOOP_CLASSPATH")
- if (hadoopClasspath.isEmpty) {
- throw KyuubiSQLException("HADOOP_CLASSPATH is not set! " +
- "For more detail information on configuring HADOOP_CLASSPATH" +
-
"https://kyuubi.apache.org/docs/latest/deployment/settings.html#environments";)
+ val hadoopCp = env.get(FLINK_HADOOP_CLASSPATH)
+ hadoopCp.foreach(classpathEntries.add)
+ val extraCp = conf.get(ENGINE_FLINK_EXTRA_CLASSPATH)
+ extraCp.foreach(classpathEntries.add)
+ if (hadoopCp.isEmpty && extraCp.isEmpty) {
+ throw new KyuubiException(s"The conf of ${FLINK_HADOOP_CLASSPATH} or " +
+ s"${ENGINE_FLINK_EXTRA_CLASSPATH} is empty." +
+ s"Please set ${FLINK_HADOOP_CLASSPATH} or
${ENGINE_FLINK_EXTRA_CLASSPATH} for " +
Review Comment:
the conf should be conf.key, for example, FLINK_HADOOP_CLASSPATH should be
FLINK_HADOOP_CLASSPATH.key
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -1437,6 +1437,28 @@ object KyuubiConf {
.stringConf
.createOptional
+ val ENGINE_FLINK_MEMORY: ConfigEntry[String] =
Review Comment:
The new configs should be added in the setting.md. you can refer
docs/develop_tools/Append descriptions of new configurations to settings.md.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
