pan3793 commented on code in PR #2579:
URL: https://github.com/apache/incubator-kyuubi/pull/2579#discussion_r867330003


##########
docs/deployment/engine_on_yarn.md:
##########
@@ -175,6 +175,24 @@ If the `TopSpeedWindowing` passes, configure it in 
`$KYUUBI_HOME/conf/kyuubi-env
 $ echo "export HADOOP_CONF_DIR=/path/to/hadoop/conf" >> 
$KYUUBI_HOME/conf/kyuubi-env.sh
 ```
 
+#### Required Environment Variable
+
+The `FLINK_HADOOP_CLASSPATH` is required, too. It should contain 
`commons-collections-*.jar`, 
+`hadoop-client-runtime-*.jar`, `hadoop-client-api-*.jar` and 
`htrace-core4-*.jar`.
+All four jars are in the `HADOOP_HOME`. 

Review Comment:
   I would say this is not accurate. The `FLINK_HADOOP_CLASSPATH` should ponit 
to Hadoop client localtion, generally it compose of Hadoop client configuration 
files, e.g. `core-site.xml`, `yarn-site.xml`, and Hadoop client jars, for 
Hadoop 3, Hadoop shaded client is recommended instead of vanilla jars.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to