turboFei commented on code in PR #2593:
URL: https://github.com/apache/incubator-kyuubi/pull/2593#discussion_r867423209
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/service/TFrontendService.scala:
##########
@@ -119,30 +119,11 @@ abstract class TFrontendService(name: String)
host + ":" + actualPort
}
- private def getProxyUser(
- sessionConf: java.util.Map[String, String],
- ipAddress: String,
- realUser: String): String = {
- val proxyUser = sessionConf.get(KyuubiAuthenticationFactory.HS2_PROXY_USER)
- if (proxyUser == null) {
- realUser
- } else {
- KyuubiAuthenticationFactory.verifyProxyAccess(realUser, proxyUser,
ipAddress, hadoopConf)
- proxyUser
- }
- }
-
private def getUserName(req: TOpenSessionReq): String = {
- val realUser: String =
-
ServiceUtils.getShortName(authFactory.getRemoteUser.getOrElse(req.getUsername))
- if (req.getConfiguration == null) {
- realUser
- } else {
- getProxyUser(req.getConfiguration, authFactory.getIpAddress.orNull,
realUser)
- }
+
ServiceUtils.getShortName(authFactory.getRemoteUser.getOrElse(req.getUsername))
Review Comment:
It is not needed to verify proxy user in engine side.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
