ulysses-you commented on code in PR #2592:
URL: https://github.com/apache/incubator-kyuubi/pull/2592#discussion_r867595096
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -185,7 +185,8 @@ private[kyuubi] class EngineRef(
MetricsSystem.tracing(_.incCount(ENGINE_TOTAL))
try {
- info(s"Launching engine:\n$builder")
+ val redactedCmd =
Utils.redact(conf.get(SERVER_SECRET_REDACTION_PATTERN), builder.toString)
Review Comment:
shall we redact it before combine the submission cmd ？so we can redact the
value inside `key=value`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
