pan3793 commented on code in PR #2579: URL: https://github.com/apache/incubator-kyuubi/pull/2579#discussion_r868234180
########## conf/kyuubi-env.sh.template: ########## @@ -59,6 +60,7 @@ # export SPARK_HOME=/opt/spark # export FLINK_HOME=/opt/flink # export HIVE_HOME=/opt/hive +# export FLINK_HADOOP_CLASSPATH=/path/to/hadoop-client-runtime-*.jar:/path/to/hadoop-client-api-*.jar Review Comment: The example should be a specific version rather than a pattern, the bundled version is selected just for consistent purpose, and it's not a big deal if we forget to update the example once we upgrade the bundled hadoop version. Take `# export JAVA_HOME=/usr/jdk64/jdk1.8.0_152` as an example, we never update it but it's clear enough for users how to set it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
