pan3793 commented on code in PR #2660:
URL: https://github.com/apache/incubator-kyuubi/pull/2660#discussion_r873342163
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTable.scala:
##########
@@ -68,8 +68,13 @@ class TPCDSTable(tbl: String, scale: Int, options:
CaseInsensitiveStringMap)
override def capabilities(): util.Set[TableCapability] =
Set(TableCapability.BATCH_READ).asJava
- override def newScanBuilder(options: CaseInsensitiveStringMap): ScanBuilder
= {
- new TPCDSBatchScan(tpcdsTable, scale, schema)
+ override def newScanBuilder(scanOpts: CaseInsensitiveStringMap): ScanBuilder
= {
+ val map = new util.HashMap[String, String](scanOpts)
+ options.asScala.foreach {
+ case (k, v) => map.putIfAbsent(k, v)
+ }
+ val newOpts = new CaseInsensitiveStringMap(map)
Review Comment:
It's good to consider both SparkConf and ReadOption, can we extract it such
as `org.apache.iceberg.spark.SparkConfParser`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
