ulysses-you commented on code in PR #2668: URL: https://github.com/apache/incubator-kyuubi/pull/2668#discussion_r874381618
########## kyuubi-rest-client/src/main/java/org/apache/kyuubi/client/api/v1/dto/SessionData.java: ########## @@ -0,0 +1,136 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one or more + * contributor license agreements. See the NOTICE file distributed with + * this work for additional information regarding copyright ownership. + * The ASF licenses this file to You under the Apache License, Version 2.0 + * (the "License"); you may not use this file except in compliance with + * the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, software + * distributed under the License is distributed on an "AS IS" BASIS, + * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + * See the License for the specific language governing permissions and + * limitations under the License. + */ + +package org.apache.kyuubi.client.api.v1.dto; + +import java.util.Collections; +import java.util.Map; +import java.util.Objects; + +public class SessionData { + private SessionHandle sessionHandle; + private String user; + private String ipAddr; + private Map<String, String> conf; + private Long createTime; + private Long duration; + private Long idleTime; + + public SessionData() {} + + public SessionData( + SessionHandle sessionHandle, + String user, + String ipAddr, + Map<String, String> conf, + Long createTime, + Long duration, + Long idleTime) { + this.sessionHandle = sessionHandle; + this.user = user; + this.ipAddr = ipAddr; + this.conf = conf; + this.createTime = createTime; + this.duration = duration; + this.idleTime = idleTime; + } + + public SessionHandle getSessionHandle() { + return sessionHandle; + } + + public void setSessionHandle(SessionHandle sessionHandle) { + this.sessionHandle = sessionHandle; + } + + public String getUser() { + return user; + } + + public void setUser(String user) { + this.user = user; + } + + public String getIpAddr() { + return ipAddr; + } + + public void setIpAddr(String ipAddr) { + this.ipAddr = ipAddr; + } + + public Map<String, String> getConf() { + if (null == conf) { + return Collections.emptyMap(); + } + return conf; + } + + public void setConf(Map<String, String> conf) { + this.conf = conf; + } + + public Long getCreateTime() { + return createTime; + } + + public void setCreateTime(Long createTime) { + this.createTime = createTime; + } + + public Long getDuration() { + return duration; + } + + public void setDuration(Long duration) { + this.duration = duration; + } + + public Long getIdleTime() { + return idleTime; + } + + public void setIdleTime(Long idleTime) { + this.idleTime = idleTime; + } + + @Override + public boolean equals(Object o) { + if (this == o) return true; + if (o == null || getClass() != o.getClass()) return false; + SessionData that = (SessionData) o; + return Objects.equals(getSessionHandle(), that.getSessionHandle()) + && Objects.equals(getUser(), that.getUser()) + && Objects.equals(getIpAddr(), that.getIpAddr()) + && Objects.equals(getConf(), that.getConf()) + && Objects.equals(getCreateTime(), that.getCreateTime()) + && Objects.equals(getDuration(), that.getDuration()) + && Objects.equals(getIdleTime(), that.getIdleTime()); Review Comment: `SessionHandle` is enough ? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
