pan3793 commented on code in PR #2702:
URL: https://github.com/apache/incubator-kyuubi/pull/2702#discussion_r876105414
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSTable.scala:
##########
@@ -37,6 +37,14 @@ class TPCDSTable(tbl: String, scale: Int, options:
CaseInsensitiveStringMap)
// When true, use CHAR VARCHAR; otherwise use STRING
val useAnsiStringType: Boolean = options.getBoolean("useAnsiStringType",
false)
+ // 09-26-2017 v2.6.0
+ // Replaced two occurrences of "c_last_review_date" with
"c_last_review_date_sk" to be consistent
+ // with Table 2-14 (Customer Table Column Definitions) in section 2.4.7 of
the specification
+ // (fogbugz 2046).
+ //
+ // https://www.tpc.org/tpc_documents_current_versions/pdf/tpc-ds_v3.2.0.pdf
+ val useLegacyColumnName: Boolean = options.getBoolean("useLegacyColumnName",
true)
Review Comment:
TPC-DS 1.4 and 2.7 are adopted by Spark
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
