pan3793 commented on code in PR #2705:
URL: https://github.com/apache/incubator-kyuubi/pull/2705#discussion_r876803194
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -147,15 +151,42 @@ private[kyuubi] class EngineRef(
case CONNECTION => f
case _ =>
val lockPath =
- ZKPaths.makePath(s"${serverSpace}_$shareLevel", "lock", appUser,
subdomain)
+ ZKPaths.makePath(s"${serverSpace}_${shareLevel}_$engineType", "lock",
appUser, subdomain)
Review Comment:
For back port fix, I think we'd better don't change the lock path.
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/EngineRef.scala:
##########
@@ -147,15 +151,42 @@ private[kyuubi] class EngineRef(
case CONNECTION => f
case _ =>
val lockPath =
- ZKPaths.makePath(s"${serverSpace}_$shareLevel", "lock", appUser,
subdomain)
+ ZKPaths.makePath(s"${serverSpace}_${shareLevel}_$engineType", "lock",
appUser, subdomain)
Review Comment:
For back port fix, I think we'd better not change the lock path.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
