yaooqinn commented on PR #2633: URL: https://github.com/apache/incubator-kyuubi/pull/2633#issuecomment-1131454650
> > if the class is provided, why do we need an extra type to specify it? > > IMO, in project ,we always use type to choice built in classes (such as: auth, evnets). > > https://github.com/apache/incubator-kyuubi/blob/33c816240d3c1eee744bad351c5ae25c54f64139/kyuubi-server/src/main/scala/org/apache/kyuubi/server/KyuubiServer.scala#L56-L59 > > > And in `KyuubiServer`, we need `create chroot path if necessary` when ues `ZK`. `ha.type` match may better than `client.class` equals to check if discovery client is zk. the code path your provide, I don't know very well but the client.class is duplicated with type -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
