pan3793 commented on code in PR #2701:
URL: https://github.com/apache/incubator-kyuubi/pull/2701#discussion_r877688824
##########
extensions/spark/kyuubi-spark-connector-tpcds/src/main/scala/org/apache/kyuubi/spark/connector/tpcds/TPCDSSchemaUtils.scala:
##########
@@ -20,51 +20,45 @@ package org.apache.kyuubi.spark.connector.tpcds
import scala.collection.JavaConverters._
import io.trino.tpcds.Table
+import io.trino.tpcds.Table._
+import io.trino.tpcds.column._
import io.trino.tpcds.generator._
-object TPCDSTableUtils {
Review Comment:
Split the `TPCDSTableUtils` into `TPCDSSchemaUtils` and
`TPCDSStatisticsUtils`, and use ENUM instead of String as much as possible.
cc @wForget
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
