zhaomin1423 commented on code in PR #2595:
URL: https://github.com/apache/incubator-kyuubi/pull/2595#discussion_r878834345


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/engine/EngineType.scala:
##########
@@ -23,5 +23,5 @@ package org.apache.kyuubi.engine
 object EngineType extends Enumeration {
   type EngineType = Value
 
-  val SPARK_SQL, FLINK_SQL, TRINO, HIVE_SQL = Value

Review Comment:
   using jdbc engine type, and add a config of kyuubi.engine.jdbc.type to 
identify jdbc type.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to