[GitHub] [incubator-kyuubi] lightning-L opened a new issue, #2763: [Improvement] expected error code for invalid basic/spnego authentication should be SC_FORBIDDEN

[GitBox]

lightning-L opened a new issue, #2763:
URL: https://github.com/apache/incubator-kyuubi/issues/2763

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What would you like to be improved?
   
   In `KyuubiRestAuthenticationSuite`, the current expected error code for 
invalid basic/spnego authentication is `SC_INTERNAL_SERVER_ERROR`. SC_FORBIDDEN 
is the more appropriate one.
   <img width="661" alt="image" 
src="https://user-images.githubusercontent.com/21362040/170645957-75db7781-f0bc-4711-9335-28cebfe2b9b5.png";>
   <img width="655" alt="image" 
src="https://user-images.githubusercontent.com/21362040/170646002-348d1c07-04d9-4657-ad64-94c42272def1.png";>
   
   
   I also noticed that the following code in 
`AuthenticationFilter.scala#doFilter` that set the SC_FORBIDDEN is never 
executed.
   <img width="755" alt="image" 
src="https://user-images.githubusercontent.com/21362040/170646280-8b005cb8-668b-4ad9-879c-eec99c875a8f.png";>
   
   
   
   ### How should we improve?
   
   We need to add a customized ErrorHandler in the 
`KyuubiRestFrontendService.scala#startInternal`
   
   ### Are you willing to submit PR?
   
   - [X] Yes I am willing to submit a PR!


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org