ulysses-you commented on code in PR #2849:
URL: https://github.com/apache/incubator-kyuubi/pull/2849#discussion_r894168863
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/client/KyuubiSyncThriftClient.scala:
##########
@@ -161,8 +164,10 @@ class KyuubiSyncThriftClient private (
case e: Exception =>
throw KyuubiSQLException("Error while cleaning up the engine
resources", e)
} finally {
- Option(engineAliveThreadPool).foreach(_.shutdown())
- if (_aliveProbeSessionHandle != null && !remoteEngineBroken) {
+ Option(engineAliveThreadPool).foreach { pool =>
+ ThreadUtils.shutdown(pool, Duration(engineAliveProbeInterval,
TimeUnit.MILLISECONDS))
Review Comment:
If the probe request is in flight, the max flight time should not be
`engineAliveProbeInterval`. We should use a more accurate time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
