wForget commented on code in PR #2851:
URL: https://github.com/apache/incubator-kyuubi/pull/2851#discussion_r894317238
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -121,7 +121,7 @@ abstract class SessionManager(name: String) extends
CompositeService(name) {
if (session == null) {
throw KyuubiSQLException(s"Invalid $sessionHandle")
}
- info(s"$sessionHandle is closed, current opening sessions
$getOpenSessionCount")
+ info(s"$sessionHandle/${session.name} is closed, current opening sessions
$getOpenSessionCount")
Review Comment:
ditto
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/session/SessionManager.scala:
##########
@@ -100,7 +100,7 @@ abstract class SessionManager(name: String) extends
CompositeService(name) {
val handle = session.handle
session.open()
setSession(handle, session)
- info(s"$user's session with $handle is opened, current opening sessions"
+
+ info(s"$user's session with $handle/${session.name} is opened, current
opening sessions" +
Review Comment:
nit: session.name is not always configured, which may make the log dirty.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
