hddong commented on code in PR #2767: URL: https://github.com/apache/incubator-kyuubi/pull/2767#discussion_r902408046
########## dev/dependencyList: ########## @@ -87,9 +101,15 @@ metrics-json/4.2.8//metrics-json-4.2.8.jar metrics-jvm/4.2.8//metrics-jvm-4.2.8.jar netty-all/4.1.73.Final//netty-all-4.1.73.Final.jar netty-buffer/4.1.73.Final//netty-buffer-4.1.73.Final.jar +netty-codec-dns/4.1.74.Final//netty-codec-dns-4.1.74.Final.jar Review Comment: > gRPC uses a shaded netty, why do we need those netty stuff? These netty jars are a dependency of jetcd, had try to use netty-shaded, but got `ClassNoDefException`. Classes in `netty-shaded` have prefix `io.grpc`, jetcd can not recognized. Any suggestions? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
