pan3793 commented on code in PR #3230:
URL: https://github.com/apache/incubator-kyuubi/pull/3230#discussion_r945269546
##########
.github/workflows/master.yml:
##########
@@ -128,11 +127,21 @@ jobs:
java-version: ${{ matrix.java }}
cache: 'maven'
check-latest: false
- - name: Build and test Flink with maven w/o linters
- run: |
-
TEST_MODULES="externals/kyuubi-flink-sql-engine,integration-tests/kyuubi-flink-it"
+ - name: Build Flink with maven w/o linters
+ run: |
+ ENGINE_MODULE=externals/kyuubi-flink-sql-engine
+ IT_MODULE=integration-tests/kyuubi-flink-it
+ TEST_MODULES="${ENGINE_MODULE},${IT_MODULE}"
./build/mvn ${MVN_OPT} -pl ${TEST_MODULES} -Pflink-${{ matrix.flink
}} ${{ matrix.flink-archive }} -am clean install -DskipTests
+ - name: Test Flink
+ if: matrix.flink-archive == ''
+ run: |
./build/mvn ${MVN_OPT} -pl ${TEST_MODULES} -Pflink-${{ matrix.flink
}} ${{ matrix.flink-archive }} test
+ - name: Cross-version test Flink
+ if: matrix.flink-archive != ''
+ run: |
+ IT_FLINK=`echo "${{ matrix.flink-archive }}" | grep -E
'flink\-([0-9]+\.[0-9]+.[0-9]+)\-bin' -o | grep -E '[0-9]+\.[0-9]+' -o`
+ ./build/mvn ${MVN_OPT} -pl ${IT_MODULE} -Pflink-${IT_FLINK} ${{
matrix.flink-archive }} test
Review Comment:
The cross-version verification composes of:
- flink-sql-engine compiled against flink-1.15
- flink-1.14 binary tgz
- flink-1.14 mini cluster
- flink-1.14 it test suites
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
