pan3793 commented on code in PR #3230:
URL: https://github.com/apache/incubator-kyuubi/pull/3230#discussion_r945462454
##########
.github/workflows/master.yml:
##########
@@ -111,12 +111,11 @@ jobs:
- '1.15'
flink-archive: [ "" ]
comment: [ "normal" ]
- # FIXME: Cross Flink versions verification is not supported yet
- # include:
- # - java: 8
- # flink: '1.15'
- # flink-archive:
'-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.14.5
-Dflink.archive.name=flink-1.14.5-bin-scala_2.12.tgz'
- # comment: 'verify-flink-1.14'
+ include:
+ - java: 8
+ flink: '1.15'
+ flink-archive:
'-Dflink.archive.mirror=https://archive.apache.org/dist/flink/flink-1.14.5
-Dflink.archive.name=flink-1.14.5-bin-scala_2.12.tgz'
+ comment: 'verify-flink-1.14'
Review Comment:
changed to `verify-on-flink-1.14-binary`, 1.15 is acutally the default flink
version, we add this verification to ensure the default released binary tgz
works on all supported versions of flink binary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
