turboFei commented on code in PR #3213:
URL: https://github.com/apache/incubator-kyuubi/pull/3213#discussion_r946345678
##########
kyuubi-common/src/test/scala/org/apache/kyuubi/service/authentication/WithLdapServer.scala:
##########
@@ -23,22 +23,62 @@ import org.apache.kyuubi.{KyuubiFunSuite, Utils}
trait WithLdapServer extends KyuubiFunSuite {
protected var ldapServer: InMemoryDirectoryServer = _
- protected val ldapBaseDn = "ou=users"
+ protected val ldapBaseDn = "dc=example,dc=com"
protected val ldapUser = Utils.currentUser
protected val ldapUserPasswd = "ldapPassword"
+ protected val ldapGuidKey = "uid=admin,cn=Directory
Manager,ou=users,dc=example,dc=com"
+ protected val ldapBindnpw = "adminPassword"
Review Comment:
nit: ldapBindnpw => ldapBindPw
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
