turboFei commented on code in PR #3237:
URL: https://github.com/apache/incubator-kyuubi/pull/3237#discussion_r946537586
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/mysql/MySQLCommandHandler.scala:
##########
@@ -53,6 +55,8 @@ class MySQLCommandHandler(be: BackendService, execPool:
ThreadPoolExecutor)
// handle process exception, generally should send error packet
override def exceptionCaught(ctx: ChannelHandlerContext, cause: Throwable):
Unit = {
+ MetricsSystem.tracing(_.incCount(MYSQL_CONN_FAIL))
Review Comment:
move to L64, only `MetricsSystem.tracing(_.incCount(MYSQL_CONN_FAIL))` if
`ctx.channel.isActive`?
cc @pan3793
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
