turboFei commented on code in PR #3233:
URL: https://github.com/apache/incubator-kyuubi/pull/3233#discussion_r946542310
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationFilter.scala:
##########
@@ -125,6 +127,9 @@ class AuthenticationFilter(conf: KyuubiConf) extends Filter
with Logging {
}
} catch {
case e: AuthenticationException =>
+ MetricsSystem.tracing { ms =>
+ ms.incCount(REST_CONN_FAIL)
+ }
Review Comment:
```
protected def doFilter(
filterChain: FilterChain,
request: HttpServletRequest,
response: HttpServletResponse): Unit = {
try {
filterChain.doFilter(request, response)
} catch {
case e: Throwable => MetricsSystem.tracing(_.incCount(REST_CONN_FAIL)
}
}
```
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/http/authentication/AuthenticationFilter.scala:
##########
@@ -125,6 +127,9 @@ class AuthenticationFilter(conf: KyuubiConf) extends Filter
with Logging {
}
} catch {
case e: AuthenticationException =>
+ MetricsSystem.tracing { ms =>
+ ms.incCount(REST_CONN_FAIL)
+ }
Review Comment:
```
protected def doFilter(
filterChain: FilterChain,
request: HttpServletRequest,
response: HttpServletResponse): Unit = {
try {
filterChain.doFilter(request, response)
} catch {
case e: Throwable => MetricsSystem.tracing(_.incCount(REST_CONN_FAIL)
}
}
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
