pan3793 commented on PR #3213: URL: https://github.com/apache/incubator-kyuubi/pull/3213#issuecomment-1240459509
The following logic is not correct I think ``` val mail = if (!hasDomain(user) && domain.nonEmpty) (user + "@" + domain.get) else user ... nameEnuResults = ctx.search(baseDn, s"(mail=$mail)", sc) ``` I can not fully understand what's purpose of `kyuubi.authentication.ldap.attrs` by reading the descriptio "Specifies part of the search as an attribute returned by LDAP. For example: mail,name." and code. BTW, I don't find a similar conf key in Hive. I don't have much experience w/ LDAP, and I would like to provide similar configurations w/ Hive unless we have strong reasons that we can give a better solution. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
