pan3793 commented on code in PR #3477:
URL: https://github.com/apache/incubator-kyuubi/pull/3477#discussion_r967829993
##########
externals/kyuubi-trino-engine/src/main/scala/org/apache/kyuubi/engine/trino/session/TrinoSessionImpl.scala:
##########
@@ -109,6 +109,15 @@ class TrinoSessionImpl(
super.runOperation(operation)
}
+ override def getInfo(infoType: TGetInfoType): TGetInfoValue =
withAcquireRelease() {
+ infoType match {
+ case TGetInfoType.CLI_SERVER_NAME | TGetInfoType.CLI_DBMS_NAME =>
+ TGetInfoValue.stringValue("Trino")
+ case TGetInfoType.CLI_DBMS_VER =>
TGetInfoValue.stringValue(TRINO_COMPILE_VERSION)
+ case _ => throw KyuubiSQLException(s"Unrecognized GetInfoType value:
$infoType")
+ }
Review Comment:
And please provide other TGetInfoType as Hive does, otherwise may cause
client error.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
