Yikf commented on PR #3471:
URL: 
https://github.com/apache/incubator-kyuubi/pull/3471#issuecomment-1247615693

   > @Yikf I think you are talking about the issue of 
[apache/spark#36953](https://github.com/apache/spark/pull/36953), 3.3.1 will 
fine
   
   emm, sorry @ulysses-you , By looking at the 
[code](https://github.com/apache/spark/pull/36953) I think this PR is not 
solved (not actually tested yet)
   
   - In 
[line](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala#L652),
 Spark optimize logicalPlan to empty LocalRelation;
   - In 
[line](https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala#L653),
 replan this logicalPlan(LogicalRelation and it's empty) to LocalTableScanExec;
   - new check rule `ValidateSparkPlan ` looks like not catch this case, it 
will not thrown InvalidAQEPlanException, so `reOptimize ` will return a 
definite value instead of None, and it is LocalTableScanExec instead of 
BroadcastQueryStageExec
   - The assertion exception is still thrown at 
[code];(https://github.com/apache/spark/blob/master/sql/core/src/main/scala/org/apache/spark/sql/execution/adaptive/AdaptiveSparkPlanExec.scala#L369).


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to