pan3793 commented on code in PR #3524:
URL: https://github.com/apache/incubator-kyuubi/pull/3524#discussion_r981250105
##########
kyuubi-events/src/main/scala/org/apache/kyuubi/events/EventBus.scala:
##########
@@ -42,6 +44,18 @@ sealed trait EventBus {
object EventBus extends Logging {
private val defaultEventBus = EventBusLive()
+ private val conf: KyuubiConf = KyuubiConf().loadFileDefaults()
+
+ private val poolSize = conf.get(ASYNC_EVENT_HANDLER_POLL_SIZE)
+ private val waitQueueSize = conf.get(ASYNC_EVENT_HANDLER_WAIT_QUEUE_SIZE)
+ private val keepAliveMs = conf.get(ASYNC_EVENT_HANDLER_KEEPALIVE_TIME)
+
+ implicit private lazy val asyncEventExecutionContext:
ExecutionContextExecutorService =
+ ExecutionContext.fromExecutorService(ThreadUtils.newDaemonQueuedThreadPool(
+ poolSize,
+ waitQueueSize,
+ keepAliveMs,
+ "sync-event-handler-pool"))
Review Comment:
async
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2120,4 +2120,26 @@ object KyuubiConf {
_.toSet.subsetOf(Set("JSON", "JDBC", "CUSTOM")),
"Unsupported event loggers")
.createWithDefault(Seq("JSON"))
+
+ val ASYNC_EVENT_HANDLER_POLL_SIZE: ConfigEntry[Int] =
+ buildConf("kyuubi.async.event.handler.pool.size")
+ .doc("Number of threads in the async event handler thread pool")
Review Comment:
handlerPool => pool
##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -2120,4 +2120,26 @@ object KyuubiConf {
_.toSet.subsetOf(Set("JSON", "JDBC", "CUSTOM")),
"Unsupported event loggers")
.createWithDefault(Seq("JSON"))
+
+ val ASYNC_EVENT_HANDLER_POLL_SIZE: ConfigEntry[Int] =
+ buildConf("kyuubi.event.async.handlerPool.size")
+ .doc("Number of threads in the async event handler thread pool")
+ .version("1.7.0")
+ .intConf
+ .createWithDefault(10)
Review Comment:
8
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
