pan3793 commented on code in PR #3849:
URL: https://github.com/apache/incubator-kyuubi/pull/3849#discussion_r1031773262


##########
kyuubi-common/src/main/scala/org/apache/kyuubi/config/KyuubiConf.scala:
##########
@@ -114,7 +115,7 @@ case class KyuubiConf(loadSysDefault: Boolean = true) 
extends Logging {
 
   /** Get all parameters as map */

Review Comment:
   Please update the comment to mention the ordered. And better to add a simple 
UT to ensure it works as expected.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to