cfmcgrady commented on code in PR #3838:
URL: https://github.com/apache/incubator-kyuubi/pull/3838#discussion_r1036834694
##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/kyuubi/engine/spark/operation/SparkOperation.scala:
##########
@@ -193,6 +208,25 @@ abstract class SparkOperation(session: Session)
// TODO: (fchen) make all operation support arrow
getClass.getCanonicalName == classOf[ExecuteStatement].getCanonicalName
}
+
+ protected def setSessionUserSign(): Unit = {
+ (
+ session.conf.get(KYUUBI_SESSION_SIGN_PUBLICKEY),
+ session.conf.get(KYUUBI_SESSION_USER_SIGN)) match {
+ case (Some(pubKey), Some(userSign)) =>
+ setSparkLocalProperty(KYUUBI_SESSION_SIGN_PUBLICKEY, pubKey)
Review Comment:
> Server -> Engine: Server generates session signing on session user when
opening Kyuubi Session to Engine
Since each session user has its own `KYUUBI_SESSION_USER_SIGN`, but all the
user sessions within one application share one `SparkContext`, this means the
verification mechanism only works for CONNECTION/USER mode?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
