bowenliang123 opened a new issue, #3890:
URL: https://github.com/apache/incubator-kyuubi/issues/3890

   ### Code of Conduct
   
   - [X] I agree to follow this project's [Code of 
Conduct](https://www.apache.org/foundation/policies/conduct)
   
   
   ### Search before asking
   
   - [X] I have searched in the 
[issues](https://github.com/apache/incubator-kyuubi/issues?q=is%3Aissue) and 
found no similar issues.
   
   
   ### What would you like to be improved?
   
   Update `importSelectors = singleLine` to `importSelectors = binPack` in 
`.scalafmt.conf`.
   
   With about 114 occurrences, the currently used `singleLine` for 
`importSelectors` is violated with another config `maxColumn=100` by forcing 
all other import from one source formated in single line no matter how long it 
is.
   
   For example, in  `v2Commands.scala` line 31 has the length with over 202 
chars.
   And in its case, it has to importing in static way one by one , or it will 
break if import all the elements and methods of `import 
org.apache.kyuubi.plugin.spark.authz.v2Commands.CommandType.CommandType` 
   
   
(https://github.com/apache/incubator-kyuubi/blob/master/extensions/spark/kyuubi-spark-authz/src/main/scala/org/apache/kyuubi/plugin/spark/authz/v2Commands.scala#L31)
   
   Scalafmt doc for importselectors:
   https://scalameta.org/scalafmt/docs/configuration.html#importselectors
   
   ### How should we improve?
   
   _No response_
   
   ### Are you willing to submit PR?
   
   - [X] Yes. I can submit a PR independently to improve.
   - [ ] Yes. I would be willing to submit a PR with guidance from the Kyuubi 
community to improve.
   - [ ] No. I cannot submit a PR at this time.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to