bowenliang123 commented on code in PR #3877:
URL: https://github.com/apache/incubator-kyuubi/pull/3877#discussion_r1038324532


##########
externals/kyuubi-spark-sql-engine/src/main/scala/org/apache/spark/sql/kyuubi/SparkDatasetHelper.scala:
##########
@@ -73,3 +79,53 @@ object SparkDatasetHelper {
     }
   }
 }
+
+trait CompressionCodec extends Serializable {
+  def outputStream(baos: ByteArrayOutputStream): OutputStream
+  def compress(byteArray: Array[Byte]): Array[Byte] = {
+    val baos = new ByteArrayOutputStream()
+    var os: OutputStream = null
+    try {
+      os = outputStream(baos)
+      os.write(byteArray)
+    } finally {
+      if (os != null) {
+        os.close()
+      }
+    }
+    baos.toByteArray
+  }
+}
+
+object CompressionCodecFactory {
+  def createCodec(tpe: String): CompressionCodec = {
+    tpe match {
+      case "lz4" => Lz4CompressionCodec
+      case "zstd" => ZstdCompressionCodec
+      case "gzip" => GZIPCompressionCodec
+      case _ => NoCompressionCodec
+    }
+  }
+}
+
+object NoCompressionCodec extends CompressionCodec {
+  override def outputStream(baos: ByteArrayOutputStream): OutputStream = {
+    throw new UnsupportedOperationException()
+  }
+  override def compress(byteArray: Array[Byte]): Array[Byte] = byteArray
+}
+
+object Lz4CompressionCodec extends CompressionCodec {
+  override def outputStream(baos: ByteArrayOutputStream): OutputStream =
+    new LZ4FrameOutputStream(baos)
+}
+
+object ZstdCompressionCodec extends CompressionCodec {
+  override def outputStream(baos: ByteArrayOutputStream): OutputStream =
+    new ZstdOutputStreamNoFinalizer(baos)
+}
+
+object GZIPCompressionCodec extends CompressionCodec {

Review Comment:
   ```suggestion
   object GzipCompressionCodec extends CompressionCodec {
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to