pan3793 commented on code in PR #3869:
URL: https://github.com/apache/incubator-kyuubi/pull/3869#discussion_r1039418932
##########
integration-tests/kyuubi-kubernetes-it/src/test/scala/org/apache/kyuubi/kubernetes/test/WithKyuubiServerOnKubernetes.scala:
##########
@@ -25,26 +26,30 @@ trait WithKyuubiServerOnKubernetes extends KyuubiFunSuite {
protected def connectionConf: Map[String, String] = Map.empty
private val miniKubernetesClient: DefaultKubernetesClient =
MiniKube.getKubernetesClient
- protected def getJdbcUrl: String = {
- val kyuubiServers =
- miniKubernetesClient.pods().list().getItems
- assert(kyuubiServers.size() == 1)
- val kyuubiServer = kyuubiServers.get(0)
+ protected def getJdbcUrl(connectionConf: Map[String, String]): String = {
+ val kyuuubiPod = kyuubiPod
Review Comment:
this assignment can be removed after changing `def kyuubiPod` to `lazy val`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
