ulysses-you commented on code in PR #4022:
URL: https://github.com/apache/kyuubi/pull/4022#discussion_r1057452318
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/metadata/jdbc/JDBCMetadataStore.scala:
##########
@@ -78,11 +78,14 @@ class JDBCMetadataStore(conf: KyuubiConf) extends
MetadataStore with Logging {
private def initSchema(): Unit = {
val classLoader = Utils.getContextOrKyuubiClassLoader
+ val kyuubiShortVersion = KYUUBI_VERSION.split("-")(0)
val initSchemaStream: Option[InputStream] = dbType match {
case DERBY =>
-
Option(classLoader.getResourceAsStream("sql/derby/metadata-store-schema-derby.sql"))
+ Option(classLoader
+
.getResourceAsStream(s"sql/derby/metadata-store-schema-${kyuubiShortVersion}.derby.sql"))
case MYSQL =>
-
Option(classLoader.getResourceAsStream("sql/mysql/metadata-store-schema-mysql.sql"))
+ Option(classLoader
+
.getResourceAsStream(s"sql/mysql/metadata-store-schema-${kyuubiShortVersion}.mysql.sql"))
Review Comment:
we can have base file + delta file. Then base file do not need version.
delta file should have version information to specify which version cause the
changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
