bowenliang123 commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1080883236
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/engine/KyuubiApplicationManager.scala:
##########
@@ -58,6 +62,7 @@ class KyuubiApplicationManager extends
AbstractService("KyuubiApplicationManager
case NonFatal(e) => warn(s"Error stopping
${op.getClass.getSimpleName}: ${e.getMessage}")
}
}
+ FileUtils.deleteQuietly(tempDirForUpload.toFile)
Review Comment:
Addressed.
1. prefer the direct way
`FileUtils#deleteQuietly(KyuubiApplicationManager.tempDirForUpload.toFile)`
with less imports
2. use kyuubi's `Utils#deleteDirectoryRecursively` and log exception instead
of `FileUtils.deleteQuietly` which doesn't throw exceptions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
