bowenliang123 commented on code in PR #4144:
URL: https://github.com/apache/kyuubi/pull/4144#discussion_r1082530544
##########
kyuubi-server/src/main/scala/org/apache/kyuubi/server/api/v1/BatchesResource.scala:
##########
@@ -161,6 +163,40 @@ private[v1] class BatchesResource extends
ApiRequestContext with Logging {
@POST
@Consumes(Array(MediaType.APPLICATION_JSON))
def openBatchSession(request: BatchRequest): Batch = {
+ openBatchSessionInternal(request)
+ }
+
+ @ApiResponse(
+ responseCode = "200",
+ content = Array(new Content(
+ mediaType = MediaType.APPLICATION_JSON,
+ schema = new Schema(implementation = classOf[Batch]))),
+ description = "create and open a batch session with uploading resource
file")
+ @POST
+ @Path("/upload")
Review Comment:
Yes, different accepting media type with @Consumes with same combination
HTTP method and path can be handled in different actions.
Let's make it in both handlers with same path:
- `POST /batches` for `application/json` media type: accepting BatchRequest
in JSON format from HTTP request body
- `POST /batches` for `multipart/form-data` media type`: accepting two
parts from body, including the `batchRequest` form data parm for BatchRequest
in JSON format, and the other form part `resourceFile` of uploaded resource
file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org
For additional commands, e-mail: notifications-h...@kyuubi.apache.org
