ulysses-you commented on PR #4188: URL: https://github.com/apache/kyuubi/pull/4188#issuecomment-1407853040
To be honest, I do not like this new style. Here are my thoughts: 1. the new style just use more blank line which make it un-readable 2. the end on line `#xxx` is not aligned 3. the current style follows Spark -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: notifications-unsubscr...@kyuubi.apache.org For additional commands, e-mail: notifications-h...@kyuubi.apache.org
