pan3793 commented on code in PR #4212:
URL: https://github.com/apache/kyuubi/pull/4212#discussion_r1090371332
##########
kyuubi-common/src/test/scala/org/apache/kyuubi/TestUtils.scala:
##########
@@ -92,11 +92,13 @@ object TestUtils {
} else {
val linesInFile = Files.readAllLines(markdown, StandardCharsets.UTF_8)
val formatted = formatMarkdown(newOutput)
- val hint = s"$markdown out of date, please update doc with " +
- s"KYUUBI_UPDATE=1 build/mvn clean install
-Pflink-provided,spark-provided,hive-provided " +
- s"-DwildcardSuites=$agent"
- assert(linesInFile.size() === formatted.size, hint)
- linesInFile.asScala.zip(formatted).foreach { case (out, in) =>
assert(out === in, hint) }
+ linesInFile.asScala.zipWithIndex.zip(formatted).foreach { case ((str1,
index), str2) =>
+ withClue(s"$markdown out of date, as line ${index + 1} is not
expected." +
+ s" Please update doc with KYUUBI_UPDATE=1 build/mvn clean install" +
+ s" -Pflink-provided,spark-provided,hive-provided
-DwildcardSuites=$agent") {
Review Comment:
Please search "AllKyuubiConfiguration" globally and make sure all places are
updated.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
